mirror of
https://github.com/compute-blade-community/compute-blade-agent.git
synced 2026-05-05 15:43:21 +02:00
feat(bladectl)!: add more bladectl commands (#91)
This PR introduces a comprehensive set of new subcommands to bladectl, expanding its capabilities for querying and managing compute blade state. It also includes an internal refactor to simplify interface management across the gRPC API.
* `get`
* `fan`: Returns current fan speed.
* `identify`: Indicates whether the identify mode is active.
* `stealth`: Shows if stealth mode is currently enabled.
* `status`: Prints a full blade status report.
* `temperature`: Retrieves current SoC temperature.
* `critical`: Shows whether critical mode is active.
* `power`: Reports the current power source (e.g., PoE+ or USB).
* `set`
* `stealth`: Enables stealth mode.
* `remove`
* `stealth`: Disables stealth mode.
* `describe`
* `fan`: Outputs the current fan curve configuration.
* `monitor`: plot some charts about the state of the compute-blade-agent
* **gRPC API refactor**: The gRPC service definitions previously located in `internal/api` have been folded into `internal/agent`. This eliminates redundant interface declarations and ensures that all ComputeBladeAgent implementations are directly compatible with the gRPC API.
This reduces duplication and improves long-term maintainability and clarity of the interface contract.
```bash
bladectl set fan --percent 90 --blade 1 --blade 2
bladectl unset identify --blade 1 --blade 2 --blade 3 --blade 4
bladectl set stealth --blade 1 --blade 2 --blade 3 --blade 4
bladectl get status --blade 1 --blade 2 --blade 3 --blade 4
┌───────┬─────────────┬────────────────────┬───────────────┬──────────────┬──────────┬───────────────┬──────────────┐
│ BLADE │ TEMPERATURE │ FAN SPEED OVERRIDE │ FAN SPEED │ STEALTH MODE │ IDENTIFY │ CRITICAL MODE │ POWER STATUS │
├───────┼─────────────┼────────────────────┼───────────────┼──────────────┼──────────┼───────────────┼──────────────┤
│ 1 │ 50°C │ 90% │ 5825 RPM(90%) │ Active │ Off │ Off │ poe+ │
│ 2 │ 48°C │ 90% │ 5825 RPM(90%) │ Active │ Off │ Off │ poe+ │
│ 3 │ 49°C │ Not set │ 4643 RPM(56%) │ Active │ Off │ Off │ poe+ │
│ 4 │ 49°C │ Not set │ 4774 RPM(58%) │ Active │ Off │ Off │ poe+ │
└───────┴─────────────┴────────────────────┴───────────────┴──────────────┴──────────┴───────────────┴──────────────┘
bladectl rm stealth --blade 1 --blade 2 --blade 3 --blade 4
bladectl rm fan --blade 1 --blade 2 --blade 3 --blade 4
bladectl get status --blade 1 --blade 2 --blade 3 --blade 4
┌───────┬─────────────┬────────────────────┬───────────────┬──────────────┬──────────┬───────────────┬──────────────┐
│ BLADE │ TEMPERATURE │ FAN SPEED OVERRIDE │ FAN SPEED │ STEALTH MODE │ IDENTIFY │ CRITICAL MODE │ POWER STATUS │
├───────┼─────────────┼────────────────────┼───────────────┼──────────────┼──────────┼───────────────┼──────────────┤
│ 1 │ 51°C │ Not set │ 5177 RPM(66%) │ Off │ Off │ Off │ poe+ │
│ 2 │ 49°C │ Not set │ 5177 RPM(58%) │ Off │ Off │ Off │ poe+ │
│ 3 │ 50°C │ Not set │ 4659 RPM(60%) │ Off │ Off │ Off │ poe+ │
│ 4 │ 48°C │ Not set │ 4659 RPM(54%) │ Off │ Off │ Off │ poe+ │
└───────┴─────────────┴────────────────────┴───────────────┴──────────────┴──────────┴───────────────┴──────────────┘
```
when having multiple compute-blades in your bladeconfig:
```yaml
blades:
- name: 1
blade:
server: blade-pi1:8081
cert:
certificate-authority-data: <redacted>
client-certificate-data: <redacted>
client-key-data: <redacted>
- name: 2
blade:
server: blade-pi2:8081
cert:
certificate-authority-data: <redacted>
client-certificate-data: <redacted>
client-key-data: <redacted>
- name: 3
blade:
server: blade-pi3:8081
cert:
certificate-authority-data: <redacted>
client-certificate-data: <redacted>
client-key-data: <redacted>
- name: 4
blade:
server: blade-pi4:8081
cert:
certificate-authority-data: <redacted>
client-certificate-data: <redacted>
client-key-data: <redacted>
- name: 4
blade:
server: blade-pi4:8081
cert:
certificate-authority-data: <redacted>
client-certificate-data: <redacted>
client-key-data: <redacted>
current-blade: 1
```
Fixes #4, #9 (partially), should help with #5
* test: improve unit-testing
* fix: pin github.com/warthog618/gpiod
---------
Co-authored-by: Cedric Kienzler <cedric@specht-labs.de>
This commit is contained in:
Cedric Kienzler
committed by
Cedric Kienzler
Cedric Kienzler
parent
7ec49ce05c
commit
781ded8e43
@@ -2,6 +2,7 @@ package main
|
||||
|
||||
import (
|
||||
"errors"
|
||||
"fmt"
|
||||
|
||||
bladeapiv1alpha1 "github.com/compute-blade-community/compute-blade-agent/api/bladeapi/v1alpha1"
|
||||
"github.com/sierrasoftworks/humane-errors-go"
|
||||
@@ -19,69 +20,105 @@ func init() {
|
||||
cmdSetIdentify.Flags().BoolVarP(&wait, "wait", "w", false, "Wait for the identify state to be confirmed (e.g. by a physical button press)")
|
||||
cmdSet.AddCommand(cmdSetIdentify)
|
||||
cmdRemove.AddCommand(cmdRmIdentify)
|
||||
cmdGet.AddCommand(cmdGetIdentify)
|
||||
}
|
||||
|
||||
var cmdSetIdentify = &cobra.Command{
|
||||
Use: "identify",
|
||||
Example: "bladectl set identify --wait",
|
||||
Short: "interact with the compute-blade identity LED",
|
||||
RunE: runSetIdentify,
|
||||
}
|
||||
var (
|
||||
cmdSetIdentify = &cobra.Command{
|
||||
Use: "identify",
|
||||
Example: "bladectl set identify --wait",
|
||||
Short: "interact with the compute-blade identity LED",
|
||||
RunE: func(cmd *cobra.Command, _ []string) error {
|
||||
if len(bladeNames) > 1 && wait {
|
||||
return fmt.Errorf("cannot enable identify on multiple compute-blades at the same with the --wait flag")
|
||||
}
|
||||
|
||||
var cmdRmIdentify = &cobra.Command{
|
||||
Use: "identify",
|
||||
Example: "bladectl unset identify",
|
||||
Short: "remove the identify state with the compute-blade identity LED",
|
||||
RunE: runRemoveIdentify,
|
||||
}
|
||||
ctx := cmd.Context()
|
||||
clients := clientsFromContext(ctx)
|
||||
|
||||
func runSetIdentify(cmd *cobra.Command, _ []string) error {
|
||||
ctx := cmd.Context()
|
||||
client := clientFromContext(ctx)
|
||||
for _, client := range clients {
|
||||
// Check if we should wait for the identify state to be confirmed
|
||||
event := bladeapiv1alpha1.Event_IDENTIFY
|
||||
if confirm {
|
||||
event = bladeapiv1alpha1.Event_IDENTIFY_CONFIRM
|
||||
}
|
||||
|
||||
// Check if we should wait for the identify state to be confirmed
|
||||
event := bladeapiv1alpha1.Event_IDENTIFY
|
||||
if confirm {
|
||||
event = bladeapiv1alpha1.Event_IDENTIFY_CONFIRM
|
||||
// Emit the event to the compute-blade-agent
|
||||
_, err := client.EmitEvent(ctx, &bladeapiv1alpha1.EmitEventRequest{Event: event})
|
||||
if err != nil {
|
||||
return errors.New(humane.Wrap(err,
|
||||
"failed to emit event",
|
||||
"ensure the compute-blade agent is running and responsive to requests",
|
||||
"check the compute-blade agent logs for more information using 'journalctl -u compute-blade-agent.service'",
|
||||
).Display())
|
||||
}
|
||||
|
||||
// Check if we should wait for the identify state to be confirmed
|
||||
if wait {
|
||||
if _, err := client.WaitForIdentifyConfirm(ctx, &emptypb.Empty{}); err != nil {
|
||||
return errors.New(
|
||||
humane.Wrap(err, "unable to wait for confirmation",
|
||||
"ensure the compute-blade agent is running and responsive to requests",
|
||||
"check the compute-blade agent logs for more information using 'journalctl -u compute-blade-agent.service'",
|
||||
).Display())
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return nil
|
||||
},
|
||||
}
|
||||
|
||||
// Emit the event to the compute-blade-agent
|
||||
_, err := client.EmitEvent(ctx, &bladeapiv1alpha1.EmitEventRequest{Event: event})
|
||||
if err != nil {
|
||||
return errors.New(humane.Wrap(err,
|
||||
"failed to emit event",
|
||||
"ensure the compute-blade agent is running and responsive to requests",
|
||||
"check the compute-blade agent logs for more information using 'journalctl -u compute-blade-agent.service'",
|
||||
).Display(),
|
||||
)
|
||||
cmdRmIdentify = &cobra.Command{
|
||||
Use: "identify",
|
||||
Example: "bladectl unset identify",
|
||||
Short: "remove the identify state with the compute-blade identity LED",
|
||||
RunE: func(cmd *cobra.Command, _ []string) error {
|
||||
ctx := cmd.Context()
|
||||
clients := clientsFromContext(ctx)
|
||||
|
||||
for _, client := range clients {
|
||||
// Emit the event to the compute-blade-agent
|
||||
_, err := client.EmitEvent(ctx, &bladeapiv1alpha1.EmitEventRequest{Event: bladeapiv1alpha1.Event_IDENTIFY_CONFIRM})
|
||||
if err != nil {
|
||||
return errors.New(humane.Wrap(err,
|
||||
"failed to emit event",
|
||||
"ensure the compute-blade agent is running and responsive to requests",
|
||||
"check the compute-blade agent logs for more information using 'journalctl -u compute-blade-agent.service'",
|
||||
).Display())
|
||||
}
|
||||
}
|
||||
|
||||
return nil
|
||||
},
|
||||
}
|
||||
|
||||
// Check if we should wait for the identify state to be confirmed
|
||||
if !wait {
|
||||
return nil
|
||||
cmdGetIdentify = &cobra.Command{
|
||||
Use: "identify",
|
||||
Example: "bladectl get identify",
|
||||
Short: "get the identify state of the compute-blade identity LED",
|
||||
Args: cobra.ExactArgs(0),
|
||||
RunE: func(cmd *cobra.Command, _ []string) error {
|
||||
ctx := cmd.Context()
|
||||
clients := clientsFromContext(ctx)
|
||||
|
||||
for idx, client := range clients {
|
||||
bladeStatus, err := client.GetStatus(ctx, &emptypb.Empty{})
|
||||
if err != nil {
|
||||
return err
|
||||
}
|
||||
|
||||
rowPrefix := bladeNames[idx]
|
||||
if len(bladeNames) > 1 {
|
||||
rowPrefix += ": "
|
||||
} else {
|
||||
rowPrefix = ""
|
||||
}
|
||||
|
||||
fmt.Println(activeStyle(bladeStatus.IdentifyActive).Render(rowPrefix, activeLabel(bladeStatus.IdentifyActive)))
|
||||
}
|
||||
|
||||
return nil
|
||||
},
|
||||
}
|
||||
|
||||
if _, err := client.WaitForIdentifyConfirm(ctx, &emptypb.Empty{}); err != nil {
|
||||
return humane.Wrap(err, "unable to wait for confirmation", "ensure the compute-blade agent is running and responsive to requests", "check the compute-blade agent logs for more information using 'journalctl -u compute-blade-agent.service'")
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
|
||||
func runRemoveIdentify(cmd *cobra.Command, _ []string) error {
|
||||
ctx := cmd.Context()
|
||||
client := clientFromContext(ctx)
|
||||
|
||||
// Emit the event to the compute-blade-agent
|
||||
_, err := client.EmitEvent(ctx, &bladeapiv1alpha1.EmitEventRequest{Event: bladeapiv1alpha1.Event_IDENTIFY_CONFIRM})
|
||||
if err != nil {
|
||||
return errors.New(humane.Wrap(err,
|
||||
"failed to emit event",
|
||||
"ensure the compute-blade agent is running and responsive to requests",
|
||||
"check the compute-blade agent logs for more information using 'journalctl -u compute-blade-agent.service'",
|
||||
).Display(),
|
||||
)
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user